[Fix ] add batch processing when saving frames in demo #224
Conversation
Codecov ReportBase: 84.77% // Head: 84.77% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #224 +/- ##
=======================================
Coverage 84.77% 84.77%
=======================================
Files 199 199
Lines 17558 17565 +7
=======================================
+ Hits 14884 14891 +7
Misses 2674 2674
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
|
Many thanks for the update. Currently, there are conflicts that need to be manually resolved. |
|
@ttxskk you would like me to resolve them or is it something you need to do? |
I hope you can resolve them directly. |
|
@ttxskk fixed the conflict |
Currently, array_to_images converts all the array frames to images in one go (so loads them all in memory and then converts them). It might be better to convert them into batches for the following reason:
The
np.array-loading of images for example here in the demo means that we load the entire images twice into memory. This means that it can potentially oom if one is processing too many images or if the images are of high resolution.